-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to react-router@7, eslint@9, version bump the rest #101
Conversation
Aight I got there 👍 Full upgrade from Remix v1 -> v2 -> React Router v7 (which ended up breaking linting, so that's now on eslint v9 too) |
Whoops bot doesn't actually run, just the webapp |
0189734
to
1f3fa67
Compare
This still has some lingering broken things, as I had to add `"type": "module"` to `package.json` to get it to start. That's got eslint busted
npx codemod remix/2/react-router/upgrade
09bd881
to
d686032
Compare
d686032
to
85ac5e2
Compare
Rebased to collapse some "oops"-tier commits. This is actually like 3x migrations in 1 PR which makes me a bit nervous, but I've validated about as much as I can locally. Caught a few snafus, fingers crossed there aren't any weirder ones — this does a lot to change the entrypoints and adds a new prod/dev check in order to enable hot reload functionality, so it's pretty high risk. Will be monitoring and validate the deploy once it lands |
Welp this doesn't actually do a correct production build, it's missing the outside
I think I can move the code around such that there's a dev/prod script that starts up the server appropriately, but it's diverging a good bit from the template. Since this asks for a plain-JS startup script, I'm going to see if I can get that working with minimal fuss, without making it too difficult to understand and change. |
) Had to revert #101 because it wasn't starting up correctly; the built artifact did not include the actual express startup code. This PR copies in the startup script via Docker because of how the React Router v7 "framework mode" build tool functions. #101 has the original motivation for the change.
Goal here is to get fully up-to-date with modern Remix/React Router. I've gotten this working ~ correctly (as best I can tell right now) with hot reloading for server/Remix/client (which are different things! the Express server and Remix SSR are built separately, it's a PITA).
This is a draft PR while I continue working on moving to React Router v7 (from Remix v2).